From: Reimar Döffinger <Reimar.Doeffinger@gmx.de>
Date: Sun, 13 Dec 2015 22:42:38 +0000 (+0100)
Subject: Avoid MATCH_PARENT.
X-Git-Url: http://gitweb.fperrin.net/?p=Dictionary.git;a=commitdiff_plain;h=ccc13c96df8cc6c2a8d51ccf99158d6a59d24e88

Avoid MATCH_PARENT.

Unfortunately it results in completely different sizes
depending on Android version.
Interesting 2.3 and 4.4 seem to show reasonable behaviour
while 5.0 results in far too small size.
---

diff --git a/src/com/hughes/android/dictionary/DictionaryActivity.java b/src/com/hughes/android/dictionary/DictionaryActivity.java
index bd6e7c7..bd45672 100644
--- a/src/com/hughes/android/dictionary/DictionaryActivity.java
+++ b/src/com/hughes/android/dictionary/DictionaryActivity.java
@@ -713,7 +713,6 @@ public class DictionaryActivity extends ActionBarActivity {
                     final IndexInfo indexInfo = dictionaryInfo.indexInfos.get(i);
                     final View button = application.createButton(parent.getContext(),
                             dictionaryInfo, indexInfo);
-                    button.setLayoutParams(new LinearLayout.LayoutParams(application.languageButtonPixels, application.languageButtonPixels * 2 / 3));
                     final IntentLauncher intentLauncher = new IntentLauncher(parent.getContext(),
                             getLaunchIntent(getApplicationContext(),
                                     application.getPath(dictionaryInfo.uncompressedFilename),
diff --git a/src/com/hughes/android/dictionary/DictionaryApplication.java b/src/com/hughes/android/dictionary/DictionaryApplication.java
index 3a97034..a94ed53 100644
--- a/src/com/hughes/android/dictionary/DictionaryApplication.java
+++ b/src/com/hughes/android/dictionary/DictionaryApplication.java
@@ -528,7 +528,7 @@ public class DictionaryApplication extends Application {
             button.setScaleType(ScaleType.FIT_CENTER);
             result = button;
         }
-        result.setLayoutParams(new LinearLayout.LayoutParams(languageButtonPixels, LinearLayout.LayoutParams.MATCH_PARENT));
+        result.setLayoutParams(new LinearLayout.LayoutParams(languageButtonPixels, languageButtonPixels * 2 / 3));
         return result;
     }