From d7f9aa76c451cbcf75cb507a566b9de719214360 Mon Sep 17 00:00:00 2001
From: =?utf8?q?Reimar=20D=C3=B6ffinger?= <Reimar.Doeffinger@gmx.de>
Date: Sat, 27 Feb 2016 14:20:42 +0100
Subject: [PATCH] Add text to all RuntimeExceptions.

---
 .../android/dictionary/DictionaryManagerActivity.java       | 2 +-
 src/com/hughes/android/dictionary/HtmlDisplayActivity.java  | 2 +-
 src/com/hughes/android/dictionary/engine/HtmlEntry.java     | 6 +++---
 src/com/hughes/android/dictionary/engine/TextEntry.java     | 2 +-
 4 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/com/hughes/android/dictionary/DictionaryManagerActivity.java b/src/com/hughes/android/dictionary/DictionaryManagerActivity.java
index 3c4a0ea..0d12ad0 100644
--- a/src/com/hughes/android/dictionary/DictionaryManagerActivity.java
+++ b/src/com/hughes/android/dictionary/DictionaryManagerActivity.java
@@ -664,7 +664,7 @@ public class DictionaryManagerActivity extends ActionBarActivity {
                         .getExternalStorageDirectory(), destFile)));
             }
         } catch (MalformedURLException e) {
-            throw new RuntimeException(e);
+            throw new RuntimeException("Download manager refuses download URL!", e);
         }
         downloadManager.enqueue(request);
         downloadButton.setText("X");
diff --git a/src/com/hughes/android/dictionary/HtmlDisplayActivity.java b/src/com/hughes/android/dictionary/HtmlDisplayActivity.java
index b174da6..bf8eda2 100644
--- a/src/com/hughes/android/dictionary/HtmlDisplayActivity.java
+++ b/src/com/hughes/android/dictionary/HtmlDisplayActivity.java
@@ -90,7 +90,7 @@ public final class HtmlDisplayActivity extends ActionBarActivity {
             // No way to get pure UTF-8 data into WebView
             html = Base64.encodeToString(html.getBytes("UTF-8"), Base64.DEFAULT);
         } catch (UnsupportedEncodingException e) {
-            throw new RuntimeException(e);
+            throw new RuntimeException("Missing UTF-8 support?!", e);
         }
         // Use loadURL to allow specifying a charset
         webView.loadUrl("data:text/html;charset=utf-8;base64," + html);
diff --git a/src/com/hughes/android/dictionary/engine/HtmlEntry.java b/src/com/hughes/android/dictionary/engine/HtmlEntry.java
index 4d7b534..f5ea520 100644
--- a/src/com/hughes/android/dictionary/engine/HtmlEntry.java
+++ b/src/com/hughes/android/dictionary/engine/HtmlEntry.java
@@ -246,7 +246,7 @@ public class HtmlEntry extends AbstractEntry implements Comparable<HtmlEntry> {
                 try {
                     html = new String(data.get(index), "UTF-8");
                 } catch (UnsupportedEncodingException e) {
-                    throw new RuntimeException(e);
+                    throw new RuntimeException("Dictionary HTML data corrupted", e);
                 }
                 htmlRef = new SoftReference<String>(html);
                 return html;
@@ -259,14 +259,14 @@ public class HtmlEntry extends AbstractEntry implements Comparable<HtmlEntry> {
                     raf.seek(offset);
                     raf.read(zipBytes);
                 } catch (IOException e) {
-                    throw new RuntimeException(e);
+                    throw new RuntimeException("Failed to read HTML data from dictionary", e);
                 }
             }
             try {
                 final byte[] bytes = StringUtil.unzipFully(zipBytes, numBytes);
                 html = new String(bytes, "UTF-8");
             } catch (IOException e) {
-                throw new RuntimeException(e);
+                throw new RuntimeException("Dictionary HTML data corrupted", e);
             }
             htmlRef = new SoftReference<String>(html);
             return html;
diff --git a/src/com/hughes/android/dictionary/engine/TextEntry.java b/src/com/hughes/android/dictionary/engine/TextEntry.java
index 449d83d..88188de 100644
--- a/src/com/hughes/android/dictionary/engine/TextEntry.java
+++ b/src/com/hughes/android/dictionary/engine/TextEntry.java
@@ -33,7 +33,7 @@ public class TextEntry extends AbstractEntry implements RAFSerializable<TextEntr
             throws IOException {
         super(dictionary, raf, index);
         text = raf.readUTF();
-        throw new RuntimeException();
+        throw new RuntimeException("TextEntry constructor should be unreachable");
     }
 
     @Override
-- 
2.43.0