Fix issues noted by lint tools.

[Dictionary.git] / src / com / hughes / android / dictionary / engine / NormalizeComparator.java

diff --git a/src/com/hughes/android/dictionary/engine/NormalizeComparator.java b/src/com/hughes/android/dictionary/engine/NormalizeComparator.java
index 9a40a4aa15c4694e7196ccbfa26aa74855515fc1..efe05d1f58e0bd2cba2171ff7d47db90c9ca5cd7 100644 (file)
--- a/src/com/hughes/android/dictionary/engine/NormalizeComparator.java
+++ b/src/com/hughes/android/dictionary/engine/NormalizeComparator.java
@@ -20,9 +20,9 @@ import java.util.Comparator;
 
 public class NormalizeComparator implements Comparator<String> {
 
-    final Transliterator normalizer;
-    final Comparator<Object> comparator;
-    int version;
+    private final Transliterator normalizer;
+    private final Comparator<Object> comparator;
+    private final int version;
 
     public NormalizeComparator(final Transliterator normalizer,
                                final Comparator<Object> comparator, int version) {
@@ -32,17 +32,18 @@ public class NormalizeComparator implements Comparator<String> {
     }
 
     // Handles comparison between items containing "-".
-    public static int compareWithoutDash(final String a, final String b, final Comparator c, int version) {
+    // Also replaces other problematic cases like "thorn".
+    public static int compareWithoutDash(final String a, final String b, final Comparator<Object> c, int version) {
         if (version < 7) return 0;
-        String s1 = a.replace("-", "");
-        String s2 = b.replace("-", "");
+        String s1 = a.replace("-", "").replace("þ", "th").replace("Þ", "Th");
+        String s2 = b.replace("-", "").replace("þ", "th").replace("Þ", "Th");
         return c.compare(s1, s2);
     }
 
     @Override
     public int compare(final String s1, final String s2) {
-        final String n1 = normalizer.transform(s1);
-        final String n2 = normalizer.transform(s2);
+        final String n1 = normalizer == null ? s1.toLowerCase() : normalizer.transform(s1);
+        final String n2 = normalizer == null ? s2.toLowerCase() : normalizer.transform(s2);
         int cn = compareWithoutDash(n1, n2, comparator, version);
         if (cn != 0) {
             return cn;