From 070f6d37264882ce16415270773acae54c7f6c5d Mon Sep 17 00:00:00 2001 From: Thad Hughes Date: Fri, 16 Dec 2011 18:15:11 -0800 Subject: [PATCH] Test path bug. --- bugs | 8 ++++++++ .../dictionary/engine/DictionaryBuilderTest.java | 2 +- .../dictionary/parser/EnWiktionaryXmlParser.java | 12 +++++++----- 3 files changed, 16 insertions(+), 6 deletions(-) diff --git a/bugs b/bugs index 259529c..0a5f46f 100644 --- a/bugs +++ b/bugs @@ -1,3 +1,11 @@ +Setup new ICU + +Bad ordering: +===do=== + do {{wikipedia|Do (nota)|lang=it}}{{infl|it|noun|g=m}} :: do, the musical note + fare {{it-verb}} {{transitive}} :: To do + + sub-levels in translations. examples. diff --git a/src/com/hughes/android/dictionary/engine/DictionaryBuilderTest.java b/src/com/hughes/android/dictionary/engine/DictionaryBuilderTest.java index 71cb4c2..20a0172 100644 --- a/src/com/hughes/android/dictionary/engine/DictionaryBuilderTest.java +++ b/src/com/hughes/android/dictionary/engine/DictionaryBuilderTest.java @@ -119,7 +119,7 @@ public class DictionaryBuilderTest extends TestCase { // Check it again. final Dictionary dict = new Dictionary(new RandomAccessFile(dictFile.getAbsolutePath(), "r")); - final PrintStream out = new PrintStream(new File(dictFile.getName() + ".text")); + final PrintStream out = new PrintStream(new File(dictFile.getPath() + ".text")); dict.print(out); out.close(); assertFilesEqual(GOLDENS + dictName + ".text", dictFile.getPath() + ".text"); diff --git a/src/com/hughes/android/dictionary/parser/EnWiktionaryXmlParser.java b/src/com/hughes/android/dictionary/parser/EnWiktionaryXmlParser.java index 6eac29d..41c7e41 100644 --- a/src/com/hughes/android/dictionary/parser/EnWiktionaryXmlParser.java +++ b/src/com/hughes/android/dictionary/parser/EnWiktionaryXmlParser.java @@ -554,11 +554,12 @@ public class EnWiktionaryXmlParser { } finally { // Here's where we exit. // TODO: Should we make an entry even if there are no foreign list items? - if (foreignBuilder.indexOf(title) == -1) { - foreignBuilder.insert(0, title + " "); + String foreign = foreignBuilder.toString().trim(); + if (!foreign.toLowerCase().startsWith(title.toLowerCase())) { + foreign = title + " " + foreign; } for (final ListSection listSection : listSections) { - doForeignListItem(foreignBuilder.toString(), title, wordForms, listSection); + doForeignListItem(foreign, title, wordForms, listSection); } } } @@ -603,10 +604,11 @@ public class EnWiktionaryXmlParser { englishBuilder.append(text); otherIndexBuilder.addEntryWithString(indexedEntry, text, EntryTypeName.WIKTIONARY_ENGLISH_DEF_OTHER_LANG); } else if (link.equals("plural")) { - englishBuilder.append(englishTokenizer.wikiLinkText()); + englishBuilder.append(text); } else { //LOG.warning("Special link: " + englishTokenizer.token()); - englishBuilder.append(englishTokenizer.wikiLinkText()); + enIndexBuilder.addEntryWithString(indexedEntry, text, EntryTypeName.WIKTIONARY_ENGLISH_DEF_WIKI_LINK); + englishBuilder.append(text); } } else { // link == null -- 2.43.0