X-Git-Url: http://gitweb.fperrin.net/?p=Dictionary.git;a=blobdiff_plain;f=src%2Fcom%2Fhughes%2Fandroid%2Fdictionary%2Fengine%2FHtmlEntry.java;h=1e34b00a70150d187868e4a038d3821b88ebca7c;hp=937c88295e585f98dc850679b0718a4753f33683;hb=83d9dc7cd871082a82c2dd0dbb7a0ceabd7c83a0;hpb=2a89cb08c7c36c78b2276ddc8d77e470dfe7ec78 diff --git a/src/com/hughes/android/dictionary/engine/HtmlEntry.java b/src/com/hughes/android/dictionary/engine/HtmlEntry.java index 937c882..1e34b00 100644 --- a/src/com/hughes/android/dictionary/engine/HtmlEntry.java +++ b/src/com/hughes/android/dictionary/engine/HtmlEntry.java @@ -10,7 +10,6 @@ import java.io.DataInput; import java.io.DataOutput; import java.io.IOException; import java.io.PrintStream; -import java.io.RandomAccessFile; import java.io.UnsupportedEncodingException; import java.lang.ref.SoftReference; import java.nio.channels.FileChannel; @@ -21,7 +20,8 @@ public class HtmlEntry extends AbstractEntry implements Comparable { // Title is not HTML escaped. public final String title; - public final LazyHtmlLoader lazyHtmlLoader; + private final LazyHtmlLoader lazyHtmlLoader; + @SuppressWarnings("WeakerAccess") public String html; public HtmlEntry(final EntrySource entrySource, String title) { @@ -38,18 +38,18 @@ public class HtmlEntry extends AbstractEntry implements Comparable { html = null; } - public void writeBase(DataOutput raf) throws IOException { + private void writeBase(DataOutput raf) throws IOException { super.write(raf); raf.writeUTF(title); } - public void writeData(DataOutput raf) throws IOException { + private void writeData(DataOutput raf) throws IOException { final byte[] bytes = getHtml().getBytes("UTF-8"); StringUtil.writeVarInt(raf, bytes.length); raf.write(bytes); } - public static byte[] readData(DataInput raf) throws IOException { + private static byte[] readData(DataInput raf) throws IOException { int len = StringUtil.readVarInt(raf); final byte[] bytes = new byte[Math.min(len, 20 * 1024 * 1024)]; raf.readFully(bytes); @@ -132,7 +132,7 @@ public class HtmlEntry extends AbstractEntry implements Comparable { } } - public String getRawText(final boolean compact) { + private String getRawText(final boolean compact) { return title + ":\n" + getHtml(); } @@ -153,8 +153,6 @@ public class HtmlEntry extends AbstractEntry implements Comparable { public static class Row extends RowBase { - boolean isExpanded = false; - Row(final DataInput raf, final int thisRowIndex, final Index index, int extra) throws IOException { super(raf, thisRowIndex, index, extra); @@ -215,6 +213,7 @@ public class HtmlEntry extends AbstractEntry implements Comparable { return result.toString(); } + @SuppressWarnings("WeakerAccess") public static String formatQuickdicUrl(final String indexShortName, final String text) { assert !indexShortName.contains(":"); assert text.length() > 0; @@ -227,6 +226,7 @@ public class HtmlEntry extends AbstractEntry implements Comparable { // -------------------------------------------------------------------- + @SuppressWarnings("WeakerAccess") public static final class LazyHtmlLoader { final DataInput raf; final FileChannel ch; @@ -237,7 +237,7 @@ public class HtmlEntry extends AbstractEntry implements Comparable { final int index; // Not sure this volatile is right, but oh well. - volatile SoftReference htmlRef = new SoftReference(null); + volatile SoftReference htmlRef = new SoftReference<>(null); private LazyHtmlLoader(FileChannel ch, final DataInput inp, List data, int index) throws IOException { this.data = data; @@ -258,7 +258,7 @@ public class HtmlEntry extends AbstractEntry implements Comparable { raf.skipBytes(numZipBytes); } - public String getHtml() { + String getHtml() { String html = htmlRef.get(); if (html != null) { return html; @@ -269,7 +269,7 @@ public class HtmlEntry extends AbstractEntry implements Comparable { } catch (UnsupportedEncodingException e) { throw new RuntimeException("Dictionary HTML data corrupted", e); } - htmlRef = new SoftReference(html); + htmlRef = new SoftReference<>(html); return html; } System.out.println("Loading Html: numBytes=" + numBytes + ", numZipBytes=" @@ -289,7 +289,7 @@ public class HtmlEntry extends AbstractEntry implements Comparable { } catch (IOException e) { throw new RuntimeException("Dictionary HTML data corrupted", e); } - htmlRef = new SoftReference(html); + htmlRef = new SoftReference<>(html); return html; } }