]> gitweb.fperrin.net Git - djsite.git/blobdiff - quotes/tests.py
Add a pyflakes check, and fix the warnings
[djsite.git] / quotes / tests.py
index 00237fa2ec9fdfc4e30e66309f6400354cec74f4..66ff00b946b8500a034412e020f80b85fce940ad 100644 (file)
@@ -1,20 +1,22 @@
-import sys
 from django.test import TestCase, Client
 
 # Create your tests here.
-from .models import Author, Tag, Quote
+from .models import Tag, Author, Work, Quote
+import re
 
 class QuoteTest(TestCase):
     def setUp(self):
         a1 = Author.objects.create(name="JFK")
-        q1 = Quote.objects.create(text="Ich bin...", author=a1)
+        w1 = Work.objects.create(name="Berlin speech", author=a1)
+        q1 = Quote.objects.create(text="Ich bin...", work=w1)
+        self.q1 = q1
 
     def test_one(self):
         q = Quote.objects.filter(text__startswith="Ich")
         self.assertEqual(q.count(), 1)
         q = q[0]
-        self.assertEqual(q.author.name, "JFK")
-
+        self.assertEqual(q, self.q1)
+        self.assertEqual(q.work.author.name, "JFK")
 
 class ViewsTest(TestCase):
     def getPage(self, url, exp_status=200):
@@ -26,42 +28,87 @@ class ViewsTest(TestCase):
 
     def setUp(self):
         a1 = Author.objects.create(name="Author with notes",
-                                   notes="Some notes")
+                                   notes="Some notes for the author")
+        w1 = Work.objects.create(name="Context with some notes",
+                                 author=a1,
+                                 notes="Some notes for the work")
+        q1 = Quote.objects.create(text="Quote01, two tags",
+                                  work=w1,
+                                  notes="Some notes for the quote")
         t1 = Tag.objects.create(tag="tag01-1")
         t2 = Tag.objects.create(tag="tag01-2")
-        q1 = Quote.objects.create(text="Quote01, two tags", author=a1)
         q1.tags.add(t1, t2)
 
         a2 = Author.objects.create(name="Author without notes")
-        q2= Quote.objects.create(text="Quote02, no tags", author=a2)
+        w2 = Work.objects.create(name="Work without notes", author=a2)
+        q2 = Quote.objects.create(text="Quote02, no tags", work=w2)
+        self.assertSequenceEqual(q2.tags.all(), [])
 
     def test_all(self):
         content = self.getPage('all/')
         for a in Author.objects.all():
-            self.assertTrue(a.name in content)
+            self.assertIn(a.name, content)
+            self.assertIn(a.notes, content)
+        for w in Work.objects.all():
+            self.assertIn(w.name, content)
+            self.assertIn(w.notes, content)
         for q in Quote.objects.all():
-            self.assertTrue(q.text in content)
+            self.assertIn(q.text, content)
+            self.assertIn(q.notes, content)
+
+    def test_random(self):
+        seen = {}
+        for q in Quote.objects.all():
+            seen[q.id] = False
+
+        # <a href="{% url 'quotes:onequote' quote.id %}">Permalink</a>
+        permalinkre = re.compile(r'([0-9]+).*Permalink')
+
+        for i in xrange(100):
+            content = self.getPage('random')
+            m = permalinkre.search(content)
+            self.assertIsNotNone(m, content)
+            quoteid = int(m.group(1))
+            self.assertIn(quoteid, seen)
+            seen[quoteid] = True
+        for q in Quote.objects.all():
+            self.assertTrue(seen[q.id])
 
     def test_views_all_data(self):
         q = Quote.objects.filter(text__startswith="Quote01")
         self.assertEqual(q.count(), 1)
         q = q[0]
 
-        # check the individual quote page
+        # check the individual quote page; each of the note type is displayed
         quotepage = self.getPage('show/%s/' % q.id)
-        self.assertTrue(q.text in quotepage)
-        self.assertTrue("author_notes" in quotepage)
+        self.assertIn(q.text, quotepage)
+        self.assertIn("author_notes", quotepage)
+        self.assertIn("work_notes", quotepage)
+        self.assertIn("tag_link", quotepage)
         self.assertEqual(quotepage.count("tag_link"), 2)
 
-        # check the author page
-        authorpage = self.getPage('author/%s/' % q.author.id)
-        self.assertTrue(q.text in authorpage)
-        self.assertTrue("author_notes" in authorpage)
+        # check the work page; each of the note type is displayed, and
+        # the work notes are shown only once
+        workpage = self.getPage('work/%s/' % q.work.id)
+        self.assertIn(q.text, workpage)
+        self.assertIn("author_notes", workpage)
+        self.assertIn("work_notes", workpage)
+        self.assertEqual(workpage.count("work_notes"), 1)
+        self.assertIn("tag_link", workpage)
+
+        # check the author page; each of the note type is displayed, and
+        # the author notes are shown only once
+        authorpage = self.getPage('author/%s/' % q.work.author.id)
+        self.assertIn(q.text, authorpage)
+        self.assertIn("author_notes", authorpage)
+        self.assertEqual(authorpage.count("author_notes"), 1)
+        self.assertIn("work_notes", authorpage)
+        self.assertIn("tag_link", authorpage)
 
         # check the tag page
         for tag in q.tags.all():
             tagpage = self.getPage('tag/%s/' % tag.id)
-            self.assertTrue(q.text in tagpage)
+            self.assertIn(q.text, tagpage)
 
     def test_views_minimal_data(self):
         q = Quote.objects.filter(text__startswith="Quote02")
@@ -69,14 +116,23 @@ class ViewsTest(TestCase):
         q = q[0]
 
         quotepage = self.getPage('show/%s/' % q.id)
-        self.assertTrue(q.text in quotepage)
-        self.assertFalse("author_notes" in quotepage)
-        self.assertEqual(quotepage.count("tag_link"), 0)
-
-        authorpage = self.getPage('author/%s/' % q.author.id)
-        self.assertTrue(q.text in authorpage)
-        self.assertFalse("author_notes" in authorpage)
-        self.assertFalse('Quote01, two tags' in authorpage)        
+        self.assertIn(q.text, quotepage)
+        self.assertNotIn("author_notes", quotepage)
+        self.assertNotIn("work_notes", quotepage)
+        self.assertNotIn("tag_link", quotepage)
+
+        workpage = self.getPage('work/%s/' % q.work.id)
+        self.assertIn(q.text, workpage)
+        self.assertNotIn("author_notes", quotepage)
+        self.assertNotIn("work_notes", quotepage)
+        self.assertNotIn("tag_link", quotepage)
+
+        authorpage = self.getPage('author/%s/' % q.work.author.id)
+        self.assertIn(q.text, authorpage)
+        self.assertNotIn("author_notes", authorpage)
+        self.assertNotIn("work_notes", authorpage)
+        self.assertNotIn("tag_link", authorpage)
+        self.assertNotIn('Quote01, two tags', authorpage)
 
     def test_view_author_notes_once(self):
         # check that on the per-author view, the author notes aren't display
@@ -86,4 +142,4 @@ class ViewsTest(TestCase):
         a = a[0]
 
         authorpage = self.getPage('author/%s/' % a.id)
-        self.assertEqual(authorpage.count("Some notes"), 1)
+        self.assertEqual(authorpage.count("Some notes for the author"), 1)