Fix the random page to not assume 1-based, no gap indexes

[djsite.git] / quotes / views.py

diff --git a/quotes/views.py b/quotes/views.py
index d6ca24035c4a9316ad68e9b2b54c715ebd88376e..642cb433581d953dcd1fced549bd7a784ebd394d 100644 (file)
--- a/quotes/views.py
+++ b/quotes/views.py
@@ -12,13 +12,17 @@ def index(request):
 
 def onequote(request, quote_id):
     q = Quote.objects.get(id=quote_id)
-    q.incr_display()
-    context = { 'quote' : q }
-    return render(request, 'quotes/onequote.html', context)
+    return _onequote(request, q)
 
 def random(request):
     count = Quote.objects.count()
-    return onequote(request, randint(1, count))
+    q = Quote.objects.all()[randint(0, count-1)]
+    return _onequote(request, q)
+
+def _onequote(request, q):
+    q.incr_display()
+    context = { 'quote' : q }
+    return render(request, 'quotes/onequote.html', context)
 
 def tags(request, tag_id):
     tag = QuoteTag.objects.get(id=tag_id)